Skip to content

fix(autoresponder): enable immediately on an OutOfOfficeStartedEvent #9990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st3iny merged 1 commit into from
Aug 14, 2024
Merged

fix(autoresponder): enable immediately on an OutOfOfficeStartedEvent #9990

st3iny merged 1 commit into from
Aug 14, 2024

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Aug 13, 2024 •
edited
Loading

Fix #9984

Conflicts with nextcloud/server#47183

I'd propose to skip this condition if the event is an instance of OutOfOfficeStartedEvent and force enable the responder instead. Otherwise, the date check makes sense, e.g. in the case of the OutOfOfficeChangedEvent event.

See #9984 (comment)

@st3iny st3iny added this to the v4.0.0 milestone Aug 13, 2024
@st3iny st3iny requested review from kesselb and miaulalala August 13, 2024 07:24
@st3iny st3iny self-assigned this Aug 13, 2024
@st3iny st3iny requested a review from ChristophWurst as a code owner August 13, 2024 07:24
miaulalala
miaulalala reviewed Aug 13, 2024
View reviewed changes
@st3iny st3iny force-pushed the fix/autoresponder/enable-on-ooo-started branch from e31e27c to 783263d Compare August 14, 2024 06:59
@st3iny st3iny enabled auto-merge August 14, 2024 07:00
@st3iny st3iny merged commit a828f74 into main Aug 14, 2024
@st3iny st3iny deleted the fix/autoresponder/enable-on-ooo-started branch August 14, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

@kesselb kesselb Awaiting requested review from kesselb kesselb is a code owner

Assignees

@st3iny st3iny

Labels

4. to release bug feature:integration

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Autoresponder not following out of office set globally

4 participants

@st3iny @ChristophWurst @miaulalala