Skip to content

Conversation

@tacruc
Copy link
Collaborator

@tacruc tacruc commented Sep 1, 2022

@tacruc tacruc requested a review from julien-nc September 2, 2022 13:46
@codecov-commenter
Copy link

Codecov Report

Base: 57.09% // Head: 4.94% // Decreases project coverage by -52.14% ⚠️

Coverage data is based on head (c38e1cf) compared to base (3518285).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #839       +/-   ##
============================================
- Coverage     57.09%   4.94%   -52.15%     
  Complexity     1153    1153               
============================================
  Files            47      47               
  Lines          3540    3539        -1     
============================================
- Hits           2021     175     -1846     
- Misses         1519    3364     +1845     
Flag Coverage Δ
unittests 4.94% <ø> (-52.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nextcloud/apps/maps/lib/DB/Geophoto.php 0.00% <0.00%> (-100.00%) ⬇️
nextcloud/apps/maps/lib/DB/FavoriteShare.php 0.00% <0.00%> (-100.00%) ⬇️
...loud/apps/maps/lib/Controller/PhotosController.php 0.00% <0.00%> (-100.00%) ⬇️
.../apps/maps/lib/Controller/DevicesApiController.php 0.00% <0.00%> (-98.37%) ⬇️
...pps/maps/lib/Controller/FavoritesApiController.php 0.00% <0.00%> (-97.78%) ⬇️
...oud/apps/maps/lib/Controller/DevicesController.php 0.00% <0.00%> (-95.92%) ⬇️
...d/apps/maps/lib/Controller/FavoritesController.php 0.00% <0.00%> (-95.09%) ⬇️
nextcloud/apps/maps/lib/DB/FavoriteShareMapper.php 0.00% <0.00%> (-93.48%) ⬇️
...extcloud/apps/maps/lib/Service/GeophotoService.php 0.00% <0.00%> (-93.38%) ⬇️
...loud/apps/maps/lib/Controller/TracksController.php 0.00% <0.00%> (-86.45%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tacruc added 4 commits October 2, 2022 12:01
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
Signed-off-by: Arne Hamann <[email protected]>
@tacruc tacruc merged commit 77a22e5 into master Dec 29, 2022
@tacruc tacruc deleted the poc/redesign branch December 29, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants