Skip to content

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 29, 2023

Depends on #1375
Closes #442

TODO:

  • Fix grid layout
  • Write tests

@provokateurin provokateurin changed the title refactor(neon_framework): Allow relative time formatting of Durations feat(neon_framework): Support setting user status Dec 29, 2023
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch 2 times, most recently from a960ad3 to dd5074b Compare December 29, 2023 13:56
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from dd5074b to 32e94fb Compare December 29, 2023 18:16
@Leptopoda
Copy link
Member

Initial imoression: the picker looks beautiful 😍

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 32e94fb to 65e222b Compare December 30, 2023 11:34
@provokateurin
Copy link
Member Author

Just setting the icon/emoji will not work here because of a bug in server: nextcloud/server#42532

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 65e222b to 559b8fd Compare January 1, 2024 17:00
@provokateurin
Copy link
Member Author

(just a rebase)

Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20240101_182939

On small display sizes the clear at selector should be underneath the message box.

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 559b8fd to 1511dcb Compare January 2, 2024 10:51
@provokateurin
Copy link
Member Author

Putting the message input and clear at in the same line was a bit too complex and I think this now looks better than before. No tests yet, but apart from that it is done.

@provokateurin provokateurin marked this pull request as ready for review January 2, 2024 11:02
@provokateurin
Copy link
Member Author

I will rebase this onto #1418 once it is merged and change the clear at dropdown so it is more usable.

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch 2 times, most recently from 2dfe44f to 1d8b042 Compare January 6, 2024 06:58
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 1d8b042 to 70d099d Compare January 16, 2024 14:59
@provokateurin
Copy link
Member Author

just a rebase, i still need to add the tests :/ haven't looked further into mocking the client or request manager.

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch 3 times, most recently from e135b7a to c887956 Compare January 19, 2024 19:56
@provokateurin
Copy link
Member Author

@Leptopoda please review the bloc tests. I'm not sure yet if the way I did it is good, but I feel like it is the best we can do right now. Once we have more blocs with tests I'd like to merge the common logic, but there is no point in that right now.

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from c887956 to b6766cc Compare January 20, 2024 21:00
@provokateurin
Copy link
Member Author

@Leptopoda added widget tests as well, this should now have all the tests we need

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from b6766cc to 1072377 Compare January 21, 2024 11:58
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 1072377 to dc3571b Compare January 21, 2024 12:16
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from dc3571b to e77164d Compare January 23, 2024 18:14
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want feel free to send the clearAt stuff as a separate PR as this looks good

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from e77164d to 2f2d585 Compare January 27, 2024 09:05
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two things:

  1. please try to get a higher coverage in for the user status bloc
    • return a 204 status code (should retry)
    • return a not 204 status code (should emit error)
    • the if (!force && !result.hasError) { check
    • correctStatus with a predefined status set
    • whatever the line with find(userId: username);

I mean you are able to read a coverage report :P

  1. On a fresh app start/hot restart the status remains in the loading state forever.

@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 2f2d585 to 429abca Compare January 28, 2024 08:49
@provokateurin provokateurin force-pushed the feature/neon_framework/set-user-status branch from 429abca to 61e57a8 Compare January 28, 2024 08:52
@provokateurin provokateurin merged commit f4721bd into main Jan 28, 2024
@provokateurin provokateurin deleted the feature/neon_framework/set-user-status branch January 28, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support setting user status

3 participants