WIP: support date and date-time formats #749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikolas Rimikis <[email protected]>
Leptopoda
force-pushed
the
feat/dynamite/date_serialization
branch
from
cd4f91b to
796c0c7
Compare
Member
Author
|
now that we have the dynamite e2e tests we can confidently merge this one. |
provokateurin
requested changes
Oct 23, 2023
Comment on lines
+89
to
+91
| const _dartTypes = [ | ||
| 'DateTime', | ||
| ]; |
Member
There was a problem hiding this comment.
_dartKeywords already contains other dart types, so I would just add it there
| ); | ||
|
|
||
| final json = { | ||
| 'date': '2023-10-22T22:00:00.000Z', |
Member
There was a problem hiding this comment.
Suggested change
| 'date': '2023-10-22T22:00:00.000Z', | |
| 'date': '2023-10-22', |
According to https://swagger.io/docs/specification/data-models/data-types/
Member
Author
|
I'll close this for now and tackle this after we have the first releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be needed for cookbook support.
I had this on a branch from march and thought it's time :)
I also plan to implement the
base64byteformat and an option for custom formats.I plan to add a config option to dynamites build-yaml config (or a separate file) that can specify:
This would enable us to have custom formats like
unix-timeor iso 8601 duration support (the later also being needed by cookbook).I do not plan to implement it without tests though as I can see those features not being used all to frequesntly