Skip to content

Allow Vue components to be used on AngularJS pages #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tucker-m wants to merge 9 commits into from
Closed

Allow Vue components to be used on AngularJS pages #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9758a2b
got something working, vue component is on page
tucker-m Mar 10, 2021
c882661
using vueify to compile vue templates, and using webpack to import th…
tucker-m Mar 16, 2021
b1e93c8
remove unused vue_templates dir (now vue_components)
tucker-m Mar 16, 2021
0bee682
remove test component
tucker-m Mar 17, 2021
b49109a
use the vue-loader for webpack instead of vueify
tucker-m Mar 17, 2021
1351b6b
Put some nextcloud vue components on the page
tucker-m Mar 17, 2021
ce0a608
Turn part of an angular template into a vue component
tucker-m Apr 9, 2021
fc1513d
Add a component that has a conditional and loop
tucker-m May 31, 2021
5120ce9
Add a sample test for a vue component
tucker-m Jun 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion js/app/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ $('#content.app-news')
.attr('ng-controller', 'AppController as App');

/* jshint unused: false */
var app = angular.module('News', ['ngRoute', 'ngSanitize', 'ngAnimate']);
var app = angular.module('News', ['ngRoute', 'ngSanitize', 'ngAnimate', 'ngVue']);

11 changes: 11 additions & 0 deletions js/app/VueComponents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
var someComponent = require('../vue_components/component.vue').default;
someVueComponent = Vue.component('SomeComponent', someComponent);
app.value('SomeComponent', someVueComponent);

var IconLinkCompact = require('../vue_components/IconLinkCompact.vue').default;
var iconLinkCompactComponent = Vue.component('IconLinkCompact', IconLinkCompact);
app.value('IconLinkCompact', iconLinkCompactComponent);

var ExploreItems = require('../vue_components/ExploreItems.vue').default;
var exploreItems = Vue.component('ExploreItems', ExploreItems);
app.value('ExploreItems', exploreItems);
24 changes: 17 additions & 7 deletions js/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ const gulp = require('gulp'),
jshint = require('gulp-jshint'),
KarmaServer = require('karma').Server,
concat = require('gulp-concat'),
sourcemaps = require('gulp-sourcemaps');
sourcemaps = require('gulp-sourcemaps'),
webpackStream = require('webpack-stream'),
webpackConfig = require('./webpack.config.js');

// Configuration
const buildTarget = 'app.min.js';
Expand All @@ -30,18 +32,22 @@ const sources = [
'node_modules/angular-sanitize/angular-sanitize.min.js',
'node_modules/moment/min/moment-with-locales.min.js',
'node_modules/masonry-layout/dist/masonry.pkgd.min.js',
'node_modules/vue/dist/vue.js',
'node_modules/ngVue/build/index.js',
'app/App.js', 'app/Config.js', 'app/Run.js',
'controller/**/*.js',
'filter/**/*.js',
'service/**/*.js',
'gui/**/*.js',
'plugin/**/*.js',
'utility/**/*.js',
'directive/**/*.js'
'directive/**/*.js',
];
const testSources = ['tests/**/*.js'];
const watchSources = sources.concat(testSources).concat(['*.js']);
const lintSources = watchSources;
const watchSources = sources.concat(testSources);
const lintSources = watchSources.filter((item) => {
return item !== 'webpack.config.js' && item !== 'webpacked_vue_components.js';
});

// tasks
gulp.task('lint', () => {
Expand All @@ -51,12 +57,16 @@ gulp.task('lint', () => {
.pipe(jshint.reporter('fail'));
});

gulp.task('default', gulp.series('lint', () => {
return gulp.src(sources)
gulp.task('webpack', () => {
return webpackStream(webpackConfig)
.pipe(gulp.dest('./webpacked'));
});
gulp.task('default', gulp.series('lint', 'webpack', () => {
return gulp.src(sources.concat(['webpacked/webpacked_vue_components.js']))
.pipe(ngAnnotate())
.pipe(sourcemaps.init())
.pipe(concat(buildTarget))
.pipe(terser())
//.pipe(terser())
.pipe(sourcemaps.write())
.pipe(gulp.dest(destinationFolder));
}));
Expand Down
Loading