[Vue Rewrite] Move Component Files to Typescript #1922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlinjunker
changed the title
This was referenced Sep 30, 2022
Grotax
approved these changes
Sep 30, 2022
Member
Grotax
left a comment
Grotax
left a comment
There was a problem hiding this comment.
Looks good, after the other PR is merged
Signed-off-by: Devlin Junker <[email protected]>
Signed-off-by: Devlin Junker <[email protected]>
devlinjunker
force-pushed
the
components-to-typescript
branch
from
2709767 to
a9aba8a
Compare
Contributor
Author
|
rebased, double check to make sure and then we can merge |
Grotax
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Making all Component files use Typescript
Moved out of #1907
(File changes in this PR contains the updates from #1907 until it is merged)
Commits with actual changes:
Steps
Vue.extend({ ...types/directory with.vuefiles containing type definitions used throughout appUp Next