Add feature to Group starred Items per Feed

CHANGELOG.md

@@ -7,7 +7,7 @@ You can also check [on GitHub](https://github.com/nextcloud/news/releases), the
 # Unreleased
 ## [28.x.x]
 ### Changed
-
+- Add feature to Group starred Items per Feed
 
 ### Fixed
 

appinfo/routes.php

@@ -22,6 +22,7 @@
 ['name' => 'page#index', 'url' => '/folder/{folderId}', 'verb' => 'GET', 'postfix' => 'view.folderid'],
 ['name' => 'page#index', 'url' => '/recent', 'verb' => 'GET', 'postfix' => 'view.recent'],
 ['name' => 'page#index', 'url' => '/starred', 'verb' => 'GET', 'postfix' => 'view.starred'],
+['name' => 'page#index', 'url' => '/starred/{feedId}', 'verb' => 'GET', 'postfix' => 'view.starred.feed'],
 ['name' => 'page#index', 'url' => '/unread', 'verb' => 'GET', 'postfix' => 'view.unread'],
 ['name' => 'page#settings', 'url' => '/settings', 'verb' => 'GET'],
 ['name' => 'page#update_settings', 'url' => '/settings', 'verb' => 'PUT'],

lib/Controller/ItemController.php

@@ -155,7 +155,8 @@ public function index(
                         $limit,
                         $offset,
                         $oldestFirst,
-                        $search_items
+                        $search_items,
+                        $id
                     );
                     break;
             }

lib/Db/Feed.php

@@ -53,6 +53,8 @@ class Feed extends Entity implements IAPI, \JsonSerializable
     protected $folderId;
     /** @var int */
     protected $unreadCount;
+    /** @var int */
+    protected $starredCount;
     /** @var string|null */
     protected $link = null;
     /** @var bool */
@@ -322,6 +324,7 @@ public function jsonSerialize(): array
             'added',
             'folderId',
             'unreadCount',
+            'starredCount',
             'link',
             'preventUpdate',
             'deletedAt',
@@ -594,6 +597,19 @@ public function setUnreadCount(int $unreadCount): Feed
         return $this;
     }
 
+    /**
+     * @param int $starredCount
+     */
+    public function setStarredCount(int $starredCount): Feed
+    {
+        if ($this->starredCount !== $starredCount) {
+            $this->starredCount = $starredCount;
+            $this->markFieldUpdated('starredCount');
+        }
+
+        return $this;
+    }
+
     /**
      * @param int $updateErrorCount
      */

lib/Db/FeedMapperV2.php

@@ -52,20 +52,36 @@ public function __construct(IDBConnection $db, Time $time)
     public function findAllFromUser(string $userId, array $params = []): array
     {
         $builder = $this->db->getQueryBuilder();
-        $builder->select('feeds.*', $builder->func()->count('items.id', 'unreadCount'))
+        $builder
+            ->select('feeds.*')
+            ->selectAlias(
+                $builder->createFunction('COUNT(DISTINCT items_unread.id)'),
+                'unreadCount'
+            )
+            ->selectAlias(
+                $builder->createFunction('COUNT(DISTINCT items_starred.id)'),
+                'starredCount'
+            )
             ->from(static::TABLE_NAME, 'feeds')
             ->leftJoin(
                 'feeds',
                 ItemMapperV2::TABLE_NAME,
-                'items',
-                'items.feed_id = feeds.id AND items.unread = :unread'
+                'items_unread',
+                'items_unread.feed_id = feeds.id AND items_unread.unread = :unread'
+            )
+            ->leftJoin(
+                'feeds',
+                ItemMapperV2::TABLE_NAME,
+                'items_starred',
+                'items_starred.feed_id = feeds.id AND items_starred.starred = :starred'
             )
             ->where('feeds.user_id = :user_id')
             ->andWhere('feeds.deleted_at = 0')
             ->groupBy('feeds.id')
             ->setParameter('unread', true, IQueryBuilder::PARAM_BOOL)
+            ->setParameter('starred', true, IQueryBuilder::PARAM_BOOL)
             ->setParameter('user_id', $userId)
-            ->addOrderBy('title');
+            ->addOrderBy('feeds.title');
 
         return $this->findEntities($builder);
     }

lib/Db/ItemMapperV2.php

@@ -556,6 +556,7 @@ public function findAllFolder(
      * @throws ServiceValidationException
      */
     public function findAllItems(
+        int $feedId,
         string $userId,
         int $type,
         int $limit,
@@ -588,6 +589,10 @@ public function findAllItems(
             case ListType::STARRED:
                 $builder->andWhere('items.starred = :starred')
                         ->setParameter('starred', true);
+                if ($feedId !== 0) {
+                    $builder->andWhere('items.feed_id = :feedId')
+                            ->setParameter('feedId', $feedId);
+                }
                 break;
             case ListType::UNREAD:
                 $builder->andWhere('items.unread = :unread')

lib/Service/ItemServiceV2.php

@@ -388,8 +388,9 @@ public function findAllWithFilters(
         int $limit,
         int $offset,
         bool $oldestFirst,
-        array $search = []
+        array $search = [],
+        int $id = 0
     ): array {
-        return $this->mapper->findAllItems($userId, $type, $limit, $offset, $oldestFirst, $search);
+        return $this->mapper->findAllItems($id, $userId, $type, $limit, $offset, $oldestFirst, $search);
     }
 }

src/components/Sidebar.vue

@@ -48,7 +48,28 @@
 					<HistoryIcon />
 				</template>
 			</NcAppNavigationItem>
-			<NcAppNavigationItem :name="t('news', 'Starred')" icon="icon-starred" :to="{ name: ROUTES.STARRED }">
+			<NcAppNavigationItem
+				:name="t('news', 'Starred')"
+				icon="icon-starred"
+				:to="{ name: ROUTES.STARRED }"
+				:allow-collapse="true"
+				:force-menu="true"
+				:open="isStarredCollapsed"
+				@update:open="isStarredCollapsed">
+				<NcAppNavigationItem
+					v-for="group in GroupedStars"
+					:key="group.id"
+					:ref="'starred-' + group.id"
+					:name="group.title"
+					:to="{ name: ROUTES.STARRED, params: { feedId: group.id } }">
+					<template #icon>
+						<RssIcon v-if="!group.faviconLink" />
+						<span v-if="group.faviconLink" style="width: 16px; height: 16px; background-size: contain;" :style="{ backgroundImage: 'url(' + group.faviconLink + ')' }" />
+					</template>
+					<template #counter>
+						<NcCounterBubble :count="group.starredCount" />
+					</template>
+				</NcAppNavigationItem>
 				<template #counter>
 					<NcCounterBubble :count="items.starredCount" />
 				</template>
@@ -408,6 +429,10 @@ export default defineComponent({
 			return navItems
 		},
 
+		GroupedStars(): Array<Feed> {
+			return this.$store.getters.feeds.filter((item: Feed) => item.starredCount !== 0)
+		},
+
 		loading: {
 			get() {
 				return this.$store.getters.loading
@@ -502,6 +527,14 @@ export default defineComponent({
 			]
 		},
 
+		/**
+		 * Parent "Starred" is only collapsed when the route is STARRED
+		 * and there is a feedId param (i.e. viewing a specific starred group)
+		 */
+		isStarredCollapsed(): boolean {
+			// ROUTES is available via data() as this.ROUTES
+			return !!(this.$route.name === this.ROUTES.STARRED && (this.$route.params && this.$route.params.feedId))
+		},
 	},
 
 	watch: {

src/components/routes/Starred.vue

@@ -1,10 +1,10 @@
 <template>
 	<ContentTemplate
 		v-if="!loading"
+		:list-name="starredFeed ? starredFeed.title : t('news', 'Starred')"
+		:list-count="starredFeed ? starredFeed.starredCount : items.starredCount"
 		:items="starred"
-		:list-name="t('news', 'Starred')"
-		:list-count="items.starredCount"
-		fetch-key="starred"
+		:fetch-key="fetchKey"
 		@load-more="fetchMore()" />
 </template>
 
@@ -23,10 +23,29 @@ export default defineComponent({
 		ContentTemplate,
 	},
 
+	props: {
+		/**
+		 * Unique identifier of the feed whose starred entries this component displays.
+		 *
+		 * @type {string}
+		 *
+		 * Used to fetch the relevant entries from the backend and to filter the displayed items.
+		 */
+		feedId: {
+			type: String,
+			required: false,
+			default: undefined,
+		},
+	},
+
 	computed: {
 		...mapState(['items']),
 		starred(): FeedItem[] {
-			let items = this.$store.getters.starred
+			const starred = this.$store.getters.starred
+
+			let items = this.feedId
+				? starred.filter((item: FeedItem) => item.feedId === this.id)
+				: starred
 			/*
 			 * Sorting items is needed because the allItems array can contain
 			 * different orderings due to possible individual feed sorting
@@ -42,21 +61,35 @@ export default defineComponent({
 		oldestFirst() {
 			return this.$store.getters.oldestFirst
 		},
+
+		id(): number {
+			return this.feedId ? Number(this.feedId) : 0
+		},
+
+		fetchKey(): string {
+			return this.feedId ? 'starred-' + this.feedId : 'starred'
+		},
+
+		starredFeed(): Feed {
+			return this.feedId
+				? this.$store.getters.feeds.find((feed: Feed) => feed.id === this.id)
+				: undefined
+		},
 	},
 
 	created() {
 		/*
 		 * When sorting newest to oldest lastItemLoaded needs to be reset to get new items for this route
 		 */
 		if (this.oldestFirst === false) {
-			this.$store.commit(MUTATIONS.SET_LAST_ITEM_LOADED, { key: 'starred', lastItem: undefined })
+			this.$store.commit(MUTATIONS.SET_LAST_ITEM_LOADED, { key: this.fetchKey, lastItem: undefined })
 		}
 	},
 
 	methods: {
 		async fetchMore() {
-			if (!this.$store.state.items.fetchingItems.starred) {
-				this.$store.dispatch(ACTIONS.FETCH_STARRED)
+			if (!this.$store.state.items.fetchingItems[this.fetchKey]) {
+				this.$store.dispatch(ACTIONS.FETCH_STARRED, { feedId: this.id })
 			}
 		},
 	},

src/dataservices/item.service.ts

@@ -39,10 +39,11 @@ export class ItemService {
 	/**
 	 * Makes backend call to retrieve starred items
 	 *
+	 * @param feedId (id of the feed to retrieve starred items for)
 	 * @param start (id of last starred item loaded)
 	 * @return response object containing backend request response
 	 */
-	static async fetchStarred(start: number): Promise<AxiosResponse> {
+	static async fetchStarred(feedId: number, start: number): Promise<AxiosResponse> {
 		return await axios.get(API_ROUTES.ITEMS, {
 			params: {
 				limit: 40,
@@ -51,6 +52,7 @@ export class ItemService {
 				showAll: store.state.showAll,
 				type: ITEM_TYPES.STARRED,
 				offset: start,
+				...(feedId !== 0 ? { id: feedId } : {}),
 			},
 		})
 	}

src/routes/index.ts

@@ -63,7 +63,7 @@ const routes = [
 	},
 	{
 		name: ROUTES.STARRED,
-		path: '/starred',
+		path: '/starred/:feedId?',
 		component: StarredPanel,
 		props: true,
 	},

src/store/feed.ts

@@ -305,6 +305,18 @@ export const mutations = {
 		}
 	},
 
+	[FEED_MUTATION_TYPES.MODIFY_STARRED_COUNT](
+		state: FeedState,
+		{ feedId, add }: { feedId: number, add: boolean },
+	) {
+		const feed = state.feeds.find((feed: Feed) => {
+			return feed.id === feedId
+		})
+		if (feed) {
+			_.assign(feed, { starredCount: feed.starredCount + (add ? 1 : -1) })
+		}
+	},
+
 	[FEED_MUTATION_TYPES.FEED_DELETE](
 		state: FeedState,
 		feedId: number,

src/store/item.ts

@@ -171,17 +171,19 @@ export const actions = {
 	 * @param param0 ActionParams
 	 * @param param0.commit Commit param
 	 * @param param1 ActionArgs
+	 * @param param1.feedId ID of the feed
 	 * @param param1.start Start data
 	 */
 	async [FEED_ITEM_ACTION_TYPES.FETCH_STARRED](
 		{ commit }: ActionParams<ItemState>,
-		{ start }: { start: number } = { start: 0 },
+		{ feedId, start }: { feedId: number, start: number } = { feedId: 0, start: 0 },
 	) {
 		const requestId = Date.now()
 		latestFetchRequest = requestId
 
-		commit(FEED_ITEM_MUTATION_TYPES.SET_FETCHING, { key: 'starred', fetching: true })
-		const response = await ItemService.fetchStarred(start || state.lastItemLoaded.starred)
+		commit(FEED_ITEM_MUTATION_TYPES.SET_FETCHING, { key: 'starred-' + feedId, fetching: true })
+
+		const response = await ItemService.fetchStarred(feedId, start || state.lastItemLoaded['starred-' + feedId])
 
 		// skip response if outdated
 		if (latestFetchRequest !== requestId) {
@@ -198,15 +200,15 @@ export const actions = {
 		}
 
 		if (response?.data.items.length < 40) {
-			commit(FEED_ITEM_MUTATION_TYPES.SET_ALL_LOADED, { key: 'starred', loaded: true })
+			commit(FEED_ITEM_MUTATION_TYPES.SET_ALL_LOADED, { key: 'starred-' + feedId, loaded: true })
 		} else {
-			commit(FEED_ITEM_MUTATION_TYPES.SET_ALL_LOADED, { key: 'starred', loaded: false })
+			commit(FEED_ITEM_MUTATION_TYPES.SET_ALL_LOADED, { key: 'starred-' + feedId, loaded: false })
 		}
 		if (response?.data.items.length > 0) {
 			const lastItem = response?.data.items[response?.data.items.length - 1].id
-			commit(FEED_ITEM_MUTATION_TYPES.SET_LAST_ITEM_LOADED, { key: 'starred', lastItem })
+			commit(FEED_ITEM_MUTATION_TYPES.SET_LAST_ITEM_LOADED, { key: 'starred-' + feedId, lastItem })
 		}
-		commit(FEED_ITEM_MUTATION_TYPES.SET_FETCHING, { key: 'starred', fetching: false })
+		commit(FEED_ITEM_MUTATION_TYPES.SET_FETCHING, { key: 'starred-' + feedId, fetching: false })
 	},
 
 	/**
@@ -354,8 +356,10 @@ export const actions = {
 		ItemService.markStarred(item, true)
 
 		item.starred = true
+		const feedId = item.feedId
 		commit(FEED_ITEM_MUTATION_TYPES.UPDATE_ITEM, { item })
 		commit(FEED_ITEM_MUTATION_TYPES.SET_STARRED_COUNT, state.starredCount + 1)
+		commit(FEED_MUTATION_TYPES.MODIFY_STARRED_COUNT, { feedId, add: true })
 	},
 
 	/**
@@ -373,8 +377,10 @@ export const actions = {
 		ItemService.markStarred(item, false)
 
 		item.starred = false
+		const feedId = item.feedId
 		commit(FEED_ITEM_MUTATION_TYPES.UPDATE_ITEM, { item })
 		commit(FEED_ITEM_MUTATION_TYPES.SET_STARRED_COUNT, state.starredCount - 1)
+		commit(FEED_MUTATION_TYPES.MODIFY_STARRED_COUNT, { feedId, add: false })
 	},
 }
 

src/types/Feed.ts

@@ -3,6 +3,7 @@ import type { FEED_ORDER, FEED_UPDATE_MODE } from '../enums/index.ts'
 export type Feed = {
 	folderId?: number
 	unreadCount: number
+	starredCount: number
 	url: string
 	title?: string
 	autoDiscover?: boolean