feat: save starred navigation item open state #3499
+86
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wofferl
added
3. to review
API
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wofferl
force-pushed
the
feat_starred_open_state
branch
from
c0fac52 to
1dfd750
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds persistent state management for the starred navigation item's open/collapsed state, building on the grouped starred items feature from #3148. Previously, the starred section would revert to its default state on page refresh; now the user's preferred open/collapsed state is saved and restored.
Key changes:
- Added
starredOpenStateto the Vuex store with getter and mutation - Replaced the temporary
wasStarredVisitedapproach with persistent storage via provisioning API - Updated backend to include
starredOpenStatein user settings - Added comprehensive unit tests for the new functionality
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/store/app.ts | Added starredOpenState boolean to store state, with getter and mutation for managing the open/collapsed state |
| src/components/Sidebar.vue | Implemented toggleStarredOpenState method to persist state via API, replaced wasStarredVisited with isStarredOpen computed property, bound to @update:open event |
| lib/Controller/PageController.php | Added starredOpenState to the list of user settings loaded on page initialization |
| tests/javascript/unit/store/app.spec.ts | Added tests for the new getter and mutation |
| tests/javascript/unit/components/Sidebar.spec.ts | Added tests for toggle functionality, removed obsolete wasStarredVisited tests, improved test setup with proper mocks |
Signed-off-by: Wolfgang <[email protected]>
wofferl
force-pushed
the
feat_starred_open_state
branch
from
1dfd750 to
212b1d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds saving the open state to the new starred group feature introduced in #3148
Checklist