Skip to content

Conversation

@joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Sep 3, 2025

For nextcloud/server#54822

Fixes the regex to handle whitespace (i.e. when our coding standards are applied to the config.sample.php ). Remains backwards compatible.

Also some refactoring (new comments, clearer variable names, etc.)

Tested existing config.sample.php as well as the one proposed in nextcloud/server#54822.

TODO:

  • Once merged, update the Docker image that runs convert in production

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when reviewed commit by commit

@joshtrichards joshtrichards merged commit 5972292 into master Sep 4, 2025
1 check passed
@joshtrichards joshtrichards deleted the jtr/refactor-2025 branch September 4, 2025 15:03
@joshtrichards
Copy link
Member Author

@nickvergessen Can you bump a new docker-ci image for this? May already be doing so for #12 but just in case. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants