Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 28, 2023

Leading spaces are now removed as well, see diff below. It's a problem for the lists when there is no empty line in rst before.

🖼️ Screenshots of RST

State Screenshot
Before Bildschirmfoto vom 2023-03-28 07-41-46
With this PR Bildschirmfoto vom 2023-03-28 07-41-33
Fixed docs from nextcloud/server#37437 Bildschirmfoto vom 2023-03-28 07-41-40

Looks good enough for me

Comparison of RST files

--- orig.rst	2023-03-28 06:54:56.381330958 +0200
+++ config_sample_php_parameters.rst	2023-03-28 07:36:30.444177255 +0200
@@ -157,7 +157,7 @@
 Enable persistent connexions to the database.
 
 This setting uses the "persistent" option from doctrine dbal, which in turn
- uses the PDO::ATTR_PERSISTENT option from de pdo driver.
+uses the PDO::ATTR_PERSISTENT option from de pdo driver.
 
 ::
 
@@ -927,9 +927,9 @@
 The channel that Nextcloud should use to look for updates
 
 Supported values:
-  - ``daily``
-  - ``beta``
-  - ``stable``
+- ``daily``
+- ``beta``
+- ``stable``
 
 ::
 
@@ -1202,10 +1202,10 @@
 seen in the first-run wizard and on Personal pages.
 
 Defaults to:
- - Desktop client: ``https://nextcloud.com/install/#install-clients``
- - Android client: ``https://play.google.com/store/apps/details?id=com.nextcloud.client``
- - iOS client: ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8``
- - iOS client app id: ``1125420102``
+- Desktop client: ``https://nextcloud.com/install/#install-clients``
+- Android client: ``https://play.google.com/store/apps/details?id=com.nextcloud.client``
+- iOS client: ``https://itunes.apple.com/us/app/nextcloud/id1125420102?mt=8``
+- iOS client app id: ``1125420102``
 
 Apps
 ----

@nickvergessen nickvergessen merged commit a303357 into master Mar 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the techdebt/noid/update-reflection-docblock branch March 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants