Migrate to use :deep selector instead of deprecated ::v-deep

[susnux]

::v-deep is deprecated as vue moved to :deep selector for vue-3 which is also available and recommended for vue 2.7.

[susnux]

Lint issue is related to: nextcloud-libraries/stylelint-config#65

Which is merged, but we need to wait for the next release (maybe 2.3.0)

[raimund-schluessler]

Works. Can someone release a new version of https://github.com/nextcloud/stylelint-config so we can get this in?

[skjnldsv]

Works. Can someone release a new version of nextcloud/stylelint-config so we can get this in?

nextcloud-libraries/stylelint-config#67

[susnux]

Works. Can someone release a new version of https://github.com/nextcloud/stylelint-config so we can get this in?

I added a commit to update the stylelint config

[skjnldsv]

which is also available and recommended for vue 2.7.

hey @susnux , everything I found online seem to state that it's vue 3 only.
Do you have some ressources for this?

underfin/vite-plugin-vue2#200 (comment)
vitejs/vite#8959 (comment)

[raimund-schluessler]

which is also available and recommended for vue 2.7.

hey @susnux , everything I found online seem to state that it's vue 3 only.

Do you have some ressources for this?

We use ::deep in the library already.

[skjnldsv]

We use ::deep in the library already.

Yes, I saw that, weirdly, I cannot get it to work on other apps for example. See nextcloud/viewer#1420

Any clue?

[raimund-schluessler]

We use ::deep in the library already.

Yes, I saw that, weirdly, I cannot get it to work on other apps for example. See nextcloud/viewer#1420

Any clue?

No idea, why it fails there. It does work for Tasks though:

https://github.com/nextcloud/tasks/blob/a27f0f0986ae65a5666fc1d2d139c65196f4464e/src/views/AppSidebar.vue#L896

[skjnldsv]

No idea, why it fails there. It does work for Tasks though:

nextcloud/tasks@a27f0f0/src/views/AppSidebar.vue#L896

Have you checked the compiled css?

[raimund-schluessler]

No idea, why it fails there. It does work for Tasks though:

nextcloud/tasks@a27f0f0/src/views/AppSidebar.vue#L896

Have you checked the compiled css?

No, I didn't indeed.
But the compiled CSS you show in the viewer PR does come from a different place, neither touched here nor there. Maybe an issue introduced with an earlier PR?

[skjnldsv]

No, I didn't indeed.

I just did, seems alright.
I see you're one major above Viewer with the vue-loader dependency, let's see :)

[skjnldsv]

Works with vue loader >= 15.10.0 ⚠️
nextcloud-libraries/webpack-vue-config#399