Skip to content

always show the dismiss all button #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 23, 2021
Merged

always show the dismiss all button #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions css/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
.notification-wrapper {
display: flex;
flex-direction: column;
margin-bottom: 44px;
max-height: calc(100vh - 50px * 4 - 44px) !important;
Copy link
Member

@nickvergessen nickvergessen Aug 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets hope no one uses a device that is smaller than 244 pixels + 50px of the header

}

.emptycontent {
Expand All @@ -58,6 +60,10 @@
color: var(--color-text-maxcontrast);
border-top: 1px solid var(--color-border);
padding: 10px;
width: calc(100% - 10px * 2);
position: absolute;
bottom: 0px;
background-color: var(--color-main-background);

&:hover,
.icon-close {
Expand Down
4 changes: 2 additions & 2 deletions js/notifications-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/notifications-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
:object-type="n.object_type"
@remove="onRemove" />
</transition-group>
<li v-if="notifications.length > 2">
<li v-if="notifications.length > 0">
<div class="dismiss-all" @click="onDismissAll">
<span class="icon icon-close svg" :title="t('notifications', 'Dismiss all notifications')" /> {{ t('notifications', 'Dismiss all notifications') }}
</div>
Expand Down