Skip to content

Fix deleting notifications with numeric user ID #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Oct 6, 2021
Merged

Fix deleting notifications with numeric user ID #1087

nickvergessen merged 2 commits into from
Oct 6, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 6, 2021

Fix #1086

@nickvergessen nickvergessen added this to the Nextcloud 23 milestone Oct 6, 2021
@nickvergessen nickvergessen force-pushed the bugfix/1086/fix-deleting-notifications-with-numeric-userid branch from 34f0553 to 0e3f6c5 Compare October 6, 2021 08:24
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2021

Added an integration test

@nickvergessen nickvergessen force-pushed the bugfix/1086/fix-deleting-notifications-with-numeric-userid branch from 057a026 to b39650f Compare October 6, 2021 08:36
@juliusknorr juliusknorr mentioned this pull request Oct 6, 2021
Closed
@nickvergessen nickvergessen merged commit 02f671d into master Oct 6, 2021
@nickvergessen nickvergessen deleted the bugfix/1086/fix-deleting-notifications-with-numeric-userid branch October 6, 2021 10:46
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2021

/backport to stable23

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Oct 6, 2021

The backport to stable23 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2021

/backport to stable22

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2021

/backport to stable21

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 6, 2021
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 6, 2021
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 6, 2021

/backport to stable20

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

4. to release bug feature: backend 🛠️

Projects

None yet

Milestone

Nextcloud 23

Development

Successfully merging this pull request may close these issues.

Error while creating a conference - Talk

3 participants

@nickvergessen @CarlSchwan