Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Jun 2, 2022

No description provided.

@artonge artonge added this to the Nextcloud 25 milestone Jun 2, 2022
@artonge artonge self-assigned this Jun 2, 2022
Comment on lines -64 to -70
.emptycontent {
padding: 50px 0;
margin: 0;

@include icon-black-white('notifications', 'notifications', 1);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless as we use vue component for that

@artonge artonge requested review from Pytal and skjnldsv June 2, 2022 09:59
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9611 was 9300 (+3.34%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen
Copy link
Member

You can ignore the performance warning for now

@artonge artonge force-pushed the dept/include_scss_in_webpack_output branch from 7cda89b to 0b2eedc Compare June 2, 2022 16:58
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2022

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9617 was 9300 (+3.4%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 638d3a2 into master Jun 2, 2022
@nickvergessen nickvergessen deleted the dept/include_scss_in_webpack_output branch June 2, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants