Skip to content

Fix keyboard accessibility #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
Jul 29, 2022
Merged

Fix keyboard accessibility #1236

CarlSchwan merged 1 commit into from
Jul 29, 2022

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jul 25, 2022 •
edited
Loading

No description provided.

@CarlSchwan CarlSchwan self-assigned this Jul 25, 2022
@CarlSchwan CarlSchwan marked this pull request as draft July 25, 2022 10:40
@CarlSchwan CarlSchwan force-pushed the fix/keyboard-accessibility branch from 78f273d to 90f9a32 Compare July 25, 2022 10:46
nickvergessen
nickvergessen reviewed Jul 25, 2022
View reviewed changes
@nickvergessen
Copy link
Member

nickvergessen commented Jul 25, 2022

HeaderMenu is taken from core/src/components and should probably be moved to nextcloud-vue

Sounds like it.

@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Jul 25, 2022
@CarlSchwan CarlSchwan force-pushed the fix/keyboard-accessibility branch from 90f9a32 to 2fd18b7 Compare July 25, 2022 13:12
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Jul 25, 2022

HeaderMenu is taken from core/src/components and should probably be moved to nextcloud-vue

Sounds like it.

I created nextcloud-libraries/nextcloud-vue#2886 but don't think this should be blocking for this PR (we can adapt to the newer component in another PR)

@CarlSchwan CarlSchwan marked this pull request as ready for review July 25, 2022 13:25
@nickvergessen
Copy link
Member

nickvergessen commented Jul 26, 2022

Am I doing something wrong?

Neither with notifcation nor without the content is shown to me

Without

Bildschirmfoto vom 2022-07-26 10-44-01

With notification

Bildschirmfoto vom 2022-07-26 10-44-18

@CarlSchwan CarlSchwan force-pushed the fix/keyboard-accessibility branch from 2fd18b7 to fd88239 Compare July 28, 2022 12:41
@CarlSchwan
Copy link
Member Author

CarlSchwan commented Jul 28, 2022

Am I doing something wrong?

Neither with notifcation nor without the content is shown to me

Without

Bildschirmfoto vom 2022-07-26 10-44-01

With notification

Bildschirmfoto vom 2022-07-26 10-44-18

fixed now

nickvergessen
nickvergessen requested changes Jul 29, 2022
View reviewed changes
@nickvergessen nickvergessen force-pushed the fix/keyboard-accessibility branch from 0de3128 to 8b7eb8d Compare July 29, 2022 15:02
@CarlSchwan CarlSchwan merged commit 686f667 into master Jul 29, 2022
@CarlSchwan CarlSchwan deleted the fix/keyboard-accessibility branch July 29, 2022 15:07
@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Accessibility feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @nickvergessen