Skip to content

Handle empty list of notifications to delete #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 16, 2022
Merged

Handle empty list of notifications to delete #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Handle empty list of notifications to delete 
Save two query

Signed-off-by: Carl Schwan <[email protected]>
  • Loading branch information
@CarlSchwan
CarlSchwan committed Aug 16, 2022
commit 151209f2b8b87360f728f8eff39e025aa5a46eae
4 changes: 4 additions & 0 deletions lib/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,10 @@ public function delete(INotification $notification): array {
}
$statement->closeCursor();

if (count($notifications) === 0) {
return [];
}

$this->connection->beginTransaction();
try {
$shouldFlush = $this->manager->defer();
Expand Down