Skip to content

[stable24] Fix duplicate ID on settings page #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Aug 30, 2022
Merged

[stable24] Fix duplicate ID on settings page #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22f75ce
Fix duplicate ID on settings page
nickvergessen Aug 30, 2022
84e2c20
Recompile
nickvergessen Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/notifications-settings.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/notifications-settings.js.map
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 3 additions & 2 deletions src/views/UserSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@
<strong v-if="!config.is_email_set">{{ t('notifications', 'You need to set up your email address before you can receive notification emails.') }}</strong>
</div>
<p>
<label for="notify_setting_batchtime" class="notification-frequency__label">
<label for="notification_reminder_batchtime" class="notification-frequency__label">
{{ t('notifications', 'Send email reminders about unhandled notifications after:') }}
</label>
<select id="notify_setting_batchtime"
<select id="notification_reminder_batchtime"
name="notification_reminder_batchtime"
v-model="config.setting_batchtime"
class="notification-frequency__select"
@change="updateSettings()">
Expand Down