Skip to content

Fix multi-tab usage with notify_push #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 2 commits into from
Oct 7, 2022
Merged

Fix multi-tab usage with notify_push #1301

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9360576
Fix multi-tab usage with notify_push
nickvergessen Oct 6, 2022
e79ca9f
Compile assets
nextcloud-command Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix multi-tab usage with notify_push 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Oct 6, 2022
commit 9360576552c4daeb6d56237c194ec5d4e4a20929
2 changes: 1 addition & 1 deletion src/NotificationsApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export default {
*/
_fetchAfterNotifyPush() {
this.backgroundFetching = true
if (this.notifyPush && this.tabId !== this.lastTabId) {
if (this.hasNotifyPush && this.tabId !== this.lastTabId) {
console.debug('Deferring notification refresh from browser storage are notify_push event to give the last tab the chance to do it')
setTimeout(() => {
this._fetch()
Expand Down