Skip to content

[stable26] Deduplicate notifications #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 6 commits into from
Mar 31, 2023
Merged

[stable26] Deduplicate notifications #1485

nickvergessen merged 6 commits into from
Mar 31, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Mar 16, 2023 •
edited
Loading

Backport of #1484

  • Waiting for t-d

@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Mar 16, 2023
@nickvergessen nickvergessen self-assigned this Mar 16, 2023
@nickvergessen nickvergessen marked this pull request as draft March 16, 2023 16:43
@nickvergessen nickvergessen mentioned this pull request Mar 16, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2023

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9812 was 9500 (+3.28%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@blizzz blizzz mentioned this pull request Mar 20, 2023
Merged
@nickvergessen nickvergessen marked this pull request as ready for review March 21, 2023 13:02
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 26.0.1 Mar 21, 2023
@nickvergessen nickvergessen force-pushed the backport/1484/stable26 branch from 79cc03b to 266ae2b Compare March 29, 2023 07:44
@nickvergessen nickvergessen mentioned this pull request Mar 29, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 9812 was 9500 (+3.28%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen requested a review from ShGKme March 29, 2023 08:12
@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 29, 2023

Time to get it in @ShGKme

ShGKme
ShGKme approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔

Disables notifications when desktop was active 2 minutes ago

@nickvergessen nickvergessen merged commit fc57b77 into stable26 Mar 31, 2023
@nickvergessen nickvergessen deleted the backport/1484/stable26 branch March 31, 2023 12:27
@skjnldsv skjnldsv mentioned this pull request Apr 13, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

Assignees

@nickvergessen nickvergessen

Labels

2. developing enhancement

Projects

None yet

Milestone

Nextcloud 26.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @ShGKme @blizzz