Skip to content

[stable25] Add object type as data attr to notification #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Apr 20, 2023
Merged

[stable25] Add object type as data attr to notification #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add object type as data attr to notification 
Signed-off-by: Akhil <[email protected]>
  • Loading branch information
@akhil1508 @nickvergessen
akhil1508 authored and nickvergessen committed Apr 17, 2023
commit ceaa28fc3ab87c3b6167c17d2fed9c42677eb8ea
4 changes: 2 additions & 2 deletions js/notifications-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/notifications-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion src/Components/Notification.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
<template>
<li class="notification" :data-id="notificationId" :data-timestamp="timestamp">
<li class="notification"
:data-id="notificationId"
:data-timestamp="timestamp"
:data-object-type="objectType"
:data-app="app">
<div class="notification-heading">
<span class="hidden-visually">{{ absoluteDate }}</span>
<span v-if="timestamp"
Expand Down