Use the color-primary-element* variables #1545
Conversation
Signed-off-by: Simon L <[email protected]>
| } | ||
| &--white { | ||
| fill: var(--color-primary-text); | ||
| fill: var(--color-primary-element-text); |
There was a problem hiding this comment.
Those 2 colors can never diverge, both are either black or white and that does not change by the "-element" cut of :P
There was a problem hiding this comment.
I see. Then it is probably fine. However I wonder if we should still normalize this here as well.
There was a problem hiding this comment.
IIRC the problem goes even further because it still assumes it would be on primary color from the topbar, but it is on the background image, so the white might not be visible properly and instead of assigning a color we need to fall back to the normal font color, but as said. needs more testing to have clear results for all colors and states at the end.
|
Will have a look next week, but I think this is not needed (as per above). |
|
I guess we can close this? |
Explanation: the color-primary variables are not to be used in components because the introduce problems with high-contrast primary colors. Fix this by using the primary-element variables instead.