Skip to content

Fix handling of the notification icon on bright and red themes #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 3 commits into from
Aug 28, 2018
Merged

Fix handling of the notification icon on bright and red themes #156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0abc6e
Fix the inverted icon for bright colors
nickvergessen Aug 27, 2018
84dbf91
Add a white icon for red based themes
nickvergessen Aug 27, 2018
79c9dc1
Remove debugging code
nickvergessen Aug 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove debugging code 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Aug 27, 2018
commit 79c9dc14e56674f1e40c4af409bb1277bb58fba4
2 changes: 1 addition & 1 deletion js/notifications.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/notifications.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@
computed: {
iconPath: function() {
var iconPath = 'notifications';
if (this.isRedThemed()) {
iconPath += '-red-new';
}

if (this.notifications.length) {
if (this.isRedThemed()) {
Expand Down