Skip to content

Bump psalm to level 3 #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 12 commits into from
Dec 11, 2023
Merged

Bump psalm to level 3 #1747

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8c7ee94
fix(OCP): Migrate to OCP\DB\Types
nickvergessen Dec 8, 2023
d8ecfab
fix(CI): Update scripts and fix versions
nickvergessen Dec 8, 2023
89f28d6
fix(CI): Remove unmaintained library
nickvergessen Dec 8, 2023
e2d06e2
fix(API): Move to public API for Authentication where possible
nickvergessen Dec 8, 2023
5479d70
fix(API): Use typed execute*() methods
nickvergessen Dec 8, 2023
cfaea0d
fix(listener): Help psalm understand that we always have a user
nickvergessen Dec 8, 2023
282391d
fix(docs): Fix returned notification list type
nickvergessen Dec 8, 2023
561d30c
fix(mail): Make sure the timezone is not empty
nickvergessen Dec 8, 2023
02b5140
fix(push): Fix some type checks
nickvergessen Dec 8, 2023
e33e5c3
fix(CI): Bump psalm error level to 3
nickvergessen Dec 8, 2023
d7571dc
fix(CI): Fix path to psalm config.xsd
nickvergessen Dec 8, 2023
91f911c
fix(tests): Handle JSON exceptions
nickvergessen Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(docs): Fix returned notification list type 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen committed Dec 8, 2023
commit 282391d5f6a941f6617187042b864cdcde119642
2 changes: 1 addition & 1 deletion lib/Handler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ public function confirmIdsForUser(string $user, array $ids): array {
* @param int $startAfterId
* @param string $userId
* @param int $limit
* @return array [notification_id => INotification]
* @return array<int, INotification> [notification_id => INotification]
*/
public function getAfterId(int $startAfterId, string $userId, int $limit = 25): array {
$sql = $this->connection->getQueryBuilder();
Expand Down
6 changes: 3 additions & 3 deletions lib/MailNotifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public function sendEmails(int $batchSize, int $sendTime): void {
$languageCode = $userLanguages[$settings->getUserId()] ?? $fallbackLang;
$timezone = $userTimezones[$settings->getUserId()] ?? $fallbackTimeZone;

/** @var INotification[] $notifications */
/** @var array<int, INotification> $notifications */
$notifications = $this->handler->getAfterId($settings->getLastSendId(), $settings->getUserId());
if (!empty($notifications)) {
$oldestNotification = end($notifications);
Expand All @@ -183,10 +183,10 @@ public function sendEmails(int $batchSize, int $sendTime): void {
}

/**
* send an email to the user containing given list of notifications
* Send an email to the user containing given list of notifications
*
* @param Settings $settings
* @param INotification[] $notifications
* @param non-empty-array<int, INotification> $notifications
* @param string $language
* @param string $timezone
*/
Expand Down