Skip to content

[stable29] perf(push): Only get user language when needed #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Apr 9, 2024
Merged

[stable29] perf(push): Only get user language when needed #1881

nickvergessen merged 1 commit into from
Apr 9, 2024

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Apr 9, 2024

Backport of PR #1880

@backportbot backportbot bot requested a review from nickvergessen as a code owner April 9, 2024 12:42
@backportbot backportbot bot requested a review from provokateurin April 9, 2024 12:42
@backportbot backportbot bot added this to the Nextcloud 29 milestone Apr 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8549 was 8200 (+4.25%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 6e96f45 into stable29 Apr 9, 2024
@nickvergessen nickvergessen deleted the backport/1880/stable29 branch April 9, 2024 12:49
@blizzz blizzz mentioned this pull request Apr 10, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@provokateurin provokateurin Awaiting requested review from provokateurin

Assignees

@nickvergessen nickvergessen

Labels

3. to review bug feature: push 📲 performance

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

2 participants

@nickvergessen