fix: separate creation of browser notifications and sounds from Vue rendering #1947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This was referenced Jun 13, 2024
…omponent Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/1946/detach-native-notifications
branch
from
a6cd273 to
2dce190
Compare
Collaborator
Author
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
nickvergessen
approved these changes
Jun 13, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Still plays sound in normal tabs and inactive tabs with Firefox.
Couldn't test the chrome suspension thou
ShGKme
approved these changes
Jun 13, 2024
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Looks good code wise.
Testing results:
| State | Before | After | Notes |
|---|---|---|---|
| hidden | ✅ shows notification | ✅ shows notification | - |
| frozen | ? | ? | hard to test without waiting for a long time, chrome://discards has no "freeze" option |
| discarded | ❌ no notification | ❌ no notification | only solvable via worker |
Collaborator
Author
Merged
1 task
Collaborator
Author
Collaborator
Author
Merged
1 task
Closed
2 tasks
Member
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
No visual changes
🚧 Tasks
🏁 Checklist