Skip to content

Add rich object support to API #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 9 commits into from
Aug 12, 2024
Merged

Add rich object support to API #1973

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a667067
feat(api): Add support for rich objects to API
come-nc Jul 9, 2024
48b4c85
ci(openapi): Update openapi-extractor to latest
nickvergessen Jul 23, 2024
650b703
fix(app): Allow to ge thte last inserted notification ID
nickvergessen Jul 23, 2024
e855539
feat(api): Add a V3 of the API allowing to give parameters
nickvergessen Jul 23, 2024
06176e6
fix(notifications): Fix rendering of legacy notifications
nickvergessen Jul 23, 2024
67fc2d4
fix(openapi): Define rich object parameters
nickvergessen Jul 23, 2024
d5c85af
fix(openapi): Unify the route name
nickvergessen Jul 23, 2024
555568b
chore(assets): Recompile assets
nickvergessen Jul 23, 2024
78be17b
fix(tests): Fix unit tests and error catching
come-nc Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(app): Allow to ge thte last inserted notification ID 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen @come-nc
nickvergessen authored and come-nc committed Aug 5, 2024
commit 650b703895919eec9852d3a3812000792b62d489
9 changes: 7 additions & 2 deletions lib/App.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
use Symfony\Component\Console\Output\OutputInterface;

class App implements IDeferrableApp {
protected ?int $lastInsertedId = null;
public function __construct(
protected Handler $handler,
protected Push $push,
Expand All @@ -33,15 +34,19 @@ public function setOutput(OutputInterface $output): void {
* @since 8.2.0
*/
public function notify(INotification $notification): void {
$notificationId = $this->handler->add($notification);
$this->lastInsertedId = $this->handler->add($notification);

try {
$this->push->pushToDevice($notificationId, $notification);
$this->push->pushToDevice($this->lastInsertedId, $notification);
} catch (NotificationNotFoundException $e) {
$this->logger->error('Error while preparing push notification', ['exception' => $e]);
}
}

public function getLastInsertedId(): ?int {
return $this->lastInsertedId;
}

/**
* @param INotification $notification
* @return int
Expand Down