Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Aug 12, 2024

  • Migrate from Webpack to Vite, including:
    • Using ESBuild
    • Extracting CSS
Metric Before After
Build time 16s 9s
main page size 4 MB 1.3 MB JS + 0.01 MB CSS
settings page size 3.7 MB 0.6 MB JS + 0.07 MB CSS
admin-settings page size 3.6 MB 0.5 MB JS + 0.04 MB CSS
total size 6.4 MB 1.4 MB JS + 0.12 MB CSS

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 12, 2024

Checking reuse

@ShGKme ShGKme force-pushed the build/vite branch 2 times, most recently from bc1b0a6 to 6179314 Compare August 12, 2024 20:34
@nickvergessen
Copy link
Member

@ShGKme
Copy link
Contributor Author

ShGKme commented Aug 12, 2024

Checking reuse

Add css/**.css to https://github.com/nextcloud/notifications/blob/master/REUSE.toml#L15 ?

Not only. Also .map files in for .mjs and vendor.licenses.txt

ShGKme added 3 commits August 13, 2024 00:45
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested, works fine. Changes also look valid. Thanks!

@Antreesy Antreesy merged commit bd7d7e3 into master Aug 14, 2024
@Antreesy Antreesy deleted the build/vite branch August 14, 2024 15:04
@Antreesy
Copy link
Collaborator

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants