refactor: use vars for repeated calls #2188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
solracsf
force-pushed
the
useVarsCodeRepeat
branch
from
5f9c56e to
1163c63
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
Query count bot is outdated. |
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Apart from a huge diff there is nothing gained and it will break backports if needed, so I'm hesitant
Signed-off-by: Git'Fellow <[email protected]>
solracsf
force-pushed
the
useVarsCodeRepeat
branch
from
1163c63 to
7bc5992
Compare
Contributor
|
🐢 Performance warning. |
nickvergessen
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization, no functional changes.