Skip to content

fix: replace moment() with Intl formatters #2211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 3 commits into from
Feb 24, 2025
Merged

fix: replace moment() with Intl formatters #2211

Antreesy merged 3 commits into from
Feb 24, 2025

Conversation

@Antreesy
Copy link
Collaborator

@Antreesy Antreesy commented Feb 21, 2025

Copied from nextcloud/talk-desktop#1107

Comparison:

Desc en_US de_DE ru_RU
moment / Intl (with 'at') 2025-02-21_12h06_49 2025-02-21_12h07_26 2025-02-21_12h07_59
Intl (with digit) / moment 2025-02-21_12h28_50 2025-02-21_12h29_21 2025-02-21_12h29_50

@Antreesy Antreesy added this to the Nextcloud 32 milestone Feb 21, 2025
@Antreesy Antreesy requested a review from ShGKme February 21, 2025 11:47
@Antreesy Antreesy self-assigned this Feb 21, 2025
ShGKme
ShGKme reviewed Feb 21, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/services/notificationsService.js still uses moment 👀

@Antreesy
Copy link
Collaborator Author

Antreesy commented Feb 21, 2025

src/services/notificationsService.js still uses moment 👀

yes, I filtered it out somehow

@Antreesy
Copy link
Collaborator Author

Antreesy commented Feb 21, 2025

/compile /

@nextcloud-command
chore(assets): Recompile assets
5e8f4d6 
Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit ba1f0c3 into master Feb 24, 2025
41 checks passed
@Antreesy Antreesy deleted the fix/noid/moment branch February 24, 2025 12:32
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

Assignees

@Antreesy Antreesy

Labels

3. to review backport-request feature: frontend 🖌️ technical debt

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@Antreesy @ShGKme @skjnldsv @nextcloud-command