Skip to content

[stable30] fix: style and template fixes #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antreesy merged 6 commits into from
Feb 24, 2025
Merged

[stable30] fix: style and template fixes #2223

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
164c520
fix: extract IconNotification to separate component
Antreesy Sep 12, 2024
b0c70d8
fix: rewrite IconNotification to script setup, refactor code
Antreesy Sep 12, 2024
e24e3f2
fix(style): clear excessive and redundant styles
Antreesy Dec 23, 2024
ea6130d
fix(NotificationsApp): ease template
Antreesy Dec 23, 2024
5fa5642
fix(NotificationsApp): Fix 'Dismiss all' on the bottom
Antreesy Jan 27, 2025
df47e81
chore(assets): Recompile assets
nextcloud-command Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(style): clear excessive and redundant styles 
- move from separate file to component

Signed-off-by: Maksim Sukharev <[email protected]>
  • Loading branch information
@Antreesy
Antreesy committed Feb 23, 2025
commit e24e3f2147b5356263ed005eb0bfe3849be03aec
2 changes: 0 additions & 2 deletions src/Components/Notification.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,6 @@ export default {

<style lang="scss" scoped>
.notification {
background-color: var(--color-main-background);

:deep(img.notification-icon) {
display: flex;
width: 32px;
Expand Down
26 changes: 18 additions & 8 deletions src/NotificationsApp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,18 +481,28 @@ export default {
.notification-container {
/* Prevent slide animation to go out of the div */
overflow: hidden;
}

.notification-wrapper {
max-height: calc(100vh - 50px * 4);
overflow: auto;
}
&,
& :deep(*),
& :deep(*::before),
& :deep(*::after) {
box-sizing: border-box;
}

::v-deep .empty-content {
margin: 12vh 10px;
.notification-wrapper {
display: flex;
flex-direction: column;
max-height: calc(100vh - 50px * 4);
overflow: auto;
}

p {
.dismiss-all {
display: flex;
justify-content: center;
color: var(--color-text-maxcontrast);
border-top: 1px solid var(--color-border);
padding: 10px;
background-color: var(--color-main-background);
}
}

Expand Down
26 changes: 0 additions & 26 deletions src/styles/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@
opacity: 1;
}
}

* {
cursor: pointer;
}
}

svg {
Expand All @@ -45,28 +41,6 @@ svg {
}
}

.notification-container {
.notification-wrapper {
display: flex;
flex-direction: column;
}

.dismiss-all {
display: flex;
justify-content: center;
color: var(--color-text-maxcontrast);
border-top: 1px solid var(--color-border);
padding: 10px;
background-color: var(--color-main-background);
}

/* Menu arrow */
&:after {
right: 101px;
}
}


.notification {
padding-bottom: 12px;

Expand Down