Skip to content

Rest in peaceful silence after a 404 and a 503 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 1 commit into from
Sep 22, 2016
Merged

Rest in peaceful silence after a 404 and a 503 #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions js/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
$.ajax({
url: OC.linkToOCS('apps/notifications/api/v1', 2) + 'notifications/' + id + '?format=json',
type: 'DELETE',
success: function(data) {
success: function() {
self._removeNotification(id);
},
error: function() {
Expand Down Expand Up @@ -206,12 +206,16 @@
* @param {XMLHttpRequest} xhr
*/
_onFetchError: function(xhr) {
if (xhr.status === 404) {
// 404 Not Found - stop polling
this._shutDownNotifications();
if (xhr.status === 503) {
// 503 - Maintenance mode
console.debug('Shutting down notifications: instance is in maintenance mode.');
} else if (xhr.status === 404) {
// 404 - App disabled
console.debug('Shutting down notifications: app is disabled.');
} else {
OC.Notification.showTemporary('Failed to request notifications. Please try to refresh the page manually.');
console.error('Shutting down notifications: [' + xhr.status + '] ' + xhr.statusText);
}
this._shutDownNotifications();
},

/**
Expand Down