Skip to content

fix(multi-tab): Fix interactions when multiple tabs are active #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Oct 13, 2025
Merged

fix(multi-tab): Fix interactions when multiple tabs are active #2559

nickvergessen merged 2 commits into from
Oct 13, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 10, 2025 •
edited
Loading

Previous "reappearing" scenario

  • You need 2 tabs Tab1 and Tab2
  • Have notifications
  • Tab1 load the page (Tab1 is now active)
  • Open notification menu
  • Wait 10 seconds
  • Tab2 load the page (Tab2 is now active)
  • Open notification menu
  • Monitor both browser consoles in parallel
  • After Tab2 loaded notifications with 304
  • (within 20 seconds) Delete a notification in Tab1
  • (at the end of the 20 seconds) Tab1 "loads notifications" from browser storage of Tab2 (last active tab)
  • Tab1 shows the notification again
  • Tab2 loads notifications with 200
  • Tab1 "loads notifications" from browser storage of Tab2 (last active tab)
  • Tab1 drops the notification again

@nickvergessen nickvergessen self-assigned this Oct 10, 2025
@nickvergessen nickvergessen added this to the Nextcloud 33 milestone Oct 10, 2025
@nickvergessen nickvergessen force-pushed the bugfix/469/improve-parallel-feeling branch from 9d1f0f2 to 6aea75e Compare October 10, 2025 13:13
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 10, 2025 •
edited
Loading

Antreesy
Antreesy approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise works fine

@nickvergessen nickvergessen force-pushed the bugfix/469/improve-parallel-feeling branch from 6aea75e to 567bd62 Compare October 13, 2025 13:04
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 13, 2025

/backport 567bd62 to stable32

@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 13, 2025

/backport 567bd62 to stable31

@nickvergessen
fix(multi-tab): Fix interactions when multiple tabs are active
1398543 
- Deleting a notification in a tab makes that tab the active one
- Deleting all notifications makes the tab the active one
- Clicking the bell loads the newest state from the shared storage

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/469/improve-parallel-feeling branch from 567bd62 to 1398543 Compare October 13, 2025 13:19
@nickvergessen
Copy link
Member Author

nickvergessen commented Oct 13, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
29f26b2 
Signed-off-by: nextcloud-command <[email protected]>
@nickvergessen nickvergessen merged commit 1d3710b into master Oct 13, 2025
40 checks passed
@nickvergessen nickvergessen deleted the bugfix/469/improve-parallel-feeling branch October 13, 2025 13:45
@nickvergessen nickvergessen mentioned this pull request Oct 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Antreesy Antreesy Antreesy approved these changes

Assignees

@nickvergessen nickvergessen

Labels

3. to review backport-request bug feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

[Bug]: notifications should be synced across open browser tabs Click on notification bell should check for new notifications

4 participants

@nickvergessen @Antreesy @nextcloud-command