Fix notification documentation to reflect recent changes #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
commented
Jan 24, 2019
| but if it is actually from your app, you must set the parsed subject, message and action labels: | ||
| ```php | ||
| protected $factory; | ||
| class Notifier implements OCP\Notification\INotifier { |
Member
Author
There was a problem hiding this comment.
I added this to make it more clear which interface needs to be implemented (it is written in step 1 but not in step 2 :/)
Member
Author
|
/backport to stable15 |
Member
Author
|
/backport to stable14 |
Member
Author
|
/backport to stable13 |
This was referenced Jan 25, 2019
|
backport to stable15 in #258 |
|
backport to stable14 in #259 |
|
backport to stable13 in #260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.