Skip to content

[stable15] Less alerting log entries on fails #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Mar 4, 2019
Merged

[stable15] Less alerting log entries on fails #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Less alerting log entries on fails 
Signed-off-by: Joas Schilling <[email protected]>
  • Loading branch information
@nickvergessen
nickvergessen authored and Backportbot committed Feb 26, 2019
commit facd1d3481f048ee7cab9fef31a6f2d50deb1c4f
1 change: 1 addition & 0 deletions lib/Push.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ public function pushToDevice(int $id, INotification $notification) {
} catch (\Exception $e) {
$this->log->logException($e, [
'app' => 'notifications',
'level' => $e->getCode() === Http::STATUS_BAD_REQUEST ? ILogger::INFO : ILogger::WARN,
]);
continue;
}
Expand Down
1 change: 1 addition & 0 deletions tests/Unit/PushTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,7 @@ public function testPushToDeviceSending($isDebug) {
->method('logException')
->with($e, [
'app' => 'notifications',
'level' => ILogger::WARN,
]);

/** @var IResponse|\PHPUnit_Framework_MockObject_MockObject $response1 */
Expand Down