Do not send push notifications when nothing was deleted #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iOS App always sent an API request when it deleted a notification. By accident this was also done when it did the delete caused by a delete-push Until now the notificiations app always sent a delete-push in case of an API call. Meaning this circled all the time. So now we only send a push if something was actually deleted. Signed-off-by: Joas Schilling <[email protected]>
Member
Author
|
/backport to stable17 |
Member
Author
|
/backport to stable16 |
Member
Author
|
/backport to stable15 |
rullzer
approved these changes
Dec 9, 2019
Ivansss
approved these changes
Dec 9, 2019
|
backport to stable17 in #506 |
|
The backport to stable16 failed. Please do this backport manually. |
|
The backport to stable15 failed. Please do this backport manually. |
Member
Author
|
Right, we introduced this with 17 only. so no backports to 15+16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iOS App always sent an API request when it deleted a notification.
By accident this was also done when it did the delete caused by a delete-push
Until now the notificiations app always sent a delete-push in case of an API
call. Meaning this circled all the time.
So now we only send a push if something was actually deleted.
Ref nextcloud/ios#1029