Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen
Copy link
Member Author

@Pytal
Copy link
Member

Pytal commented Apr 21, 2022

@nickvergessen do we still want to add this?

@nickvergessen
Copy link
Member Author

Yes, so we can get rid of jQuery in this app

@Pytal
Copy link
Member

Pytal commented Apr 25, 2022

Yes, so we can get rid of jQuery in this app

🚀! Anything blocking other than the comments above?

@nickvergessen
Copy link
Member Author

The most important bit would be to adjust the listeners as outlined above. That is the part I failed to do.

Should e.g. allow Talk to go to the chat without a page reload
and trigger message loading already

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/proper-event-bus branch from 43be609 to c2385d9 Compare February 7, 2023 08:59
Signed-off-by: Joas Schilling <[email protected]>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

Copy link
Collaborator

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with interceptor, previous way of work shouldn't be affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants