[stable18] Also check responses of 400 errors and so delete unknown devices #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So before this PR, we tried to act on 400 errors already, but I didn't know that they throw an exception on the `post()`, so instead of performing on the response body, we `continue;` after we logged an info hushed This is of course not what was intended. Further more, since the notifications are grouped and the proxy had an error which would immediately bail out with a 400 when there was 1 broken notification, instead of sending the rest, 1 broken notification was enough to not send any notification anymore. And since we never deleted the broken device the instance didn't "heal" itself, but always broke like this. Signed-off-by: Joas Schilling <[email protected]>
rullzer
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #758