Only send desktop notifications in one tab #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
commented
Mar 29, 2021
| && this.webNotificationsGranted | ||
| && this.userStatus !== 'dnd' | ||
| && this.tabId !== this.lastTabId | ||
| && this.tabId === this.lastTabId |
Member
Author
There was a problem hiding this comment.
due to this.lastTabId = response.lastTabId in the second part of the diff in this file, we always compared <tabid> !== undefined which was always true and therefor multiple tabs gave multiple desktop notifications again.
rullzer
approved these changes
Mar 29, 2021
nickvergessen
deleted the
bugfix/noid/only-send-desktop-notifications-on-one-tab
branch
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable20 |
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling [email protected]