Skip to content

Only ask for permissions on HTTPS #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jun 11, 2021
Merged

Only ask for permissions on HTTPS #996

nickvergessen merged 1 commit into from
Jun 11, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 11, 2021 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 22 milestone Jun 11, 2021
@nickvergessen nickvergessen requested a review from szaimen June 11, 2021 06:42
@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 11, 2021

/backport to stable21

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 11, 2021

/backport to stable20

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 11, 2021

/backport to stable19

szaimen
szaimen approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work

@szaimen szaimen linked an issue Jun 11, 2021 that may be closed by this pull request
Notification icon shows new notifications when there are no new notifications when Nextcloud is accessed via HTTP #995
Closed
@nickvergessen nickvergessen merged commit 3c50cf7 into master Jun 11, 2021
@nickvergessen nickvergessen deleted the bugfix/995/only-ask-for-permissions-on-https branch June 11, 2021 08:51
This was referenced Jun 11, 2021
Merged
Merged
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 11, 2021

The backport to stable19 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Jun 16, 2021
Merged
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimen szaimen szaimen approved these changes

Assignees

No one assigned

Labels

4. to release bug feature: frontend 🖌️

Projects

None yet

Milestone

Nextcloud 22

Development

Successfully merging this pull request may close these issues.

Notification icon shows new notifications when there are no new notifications when Nextcloud is accessed via HTTP

3 participants

@nickvergessen @szaimen