-
Notifications
You must be signed in to change notification settings - Fork 3
New navigation list #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New navigation list #37
Conversation
…and store, new welcome Signed-off-by: Sebastien Marinier <[email protected]>
|
Thanks a lot already, I will review next week! |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I will take a look, but it's only a minor issue compared to the other things I found, so we can deal with it later. |
Signed-off-by: Sebastien Marinier <[email protected]>
Signed-off-by: Sebastien Marinier <[email protected]>
|
Hi @provokateurin, is everything fine or do I miss something ? |
|
Nothing wrong here, just busy with other tasks. I'll review it soon :) |
|
Sorry I forgot about this 😓 |
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work!
One additional thing I noticed but am not sure if/how it can be fixed:
When I expand a navigation item and then click on a completely different one the first item is collapsed again.
Is it possible to fix this in some way? I think it is fine UX wise, but the UI jumps around due to the collapsing item which is a bit unpleasant.
Done also (listen to events, keep a manual state) |
- don't use backend generic home route - use 'specs' and apiSpecs - child apis draw their icon in 16 - keep open states Signed-off-by: Sebastien Marinier <[email protected]>
provokateurin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! This is so much better than what we had before 😍
|
The |
Signed-off-by: Sebastien Marinier <[email protected]>
-> need to upgrade the AppManager interface up to NC 29 (wich is minimum required) |
|
Thanks again! I'm going to make a new release in the next days, so everyone will get these nice improvements. |
|
Thanks you Kate! i happened to see a recent post on LinkedIn concerning this app (https://www.linkedin.com/posts/nextcloud-gmbh_integrate-nextcloud-into-your-app-with-the-activity-7265793671776608256-xEn-?utm_source=share&utm_medium=member_desktop). I'm glad to have been able to contribute! |

(All this came mainly from my previous dev)