Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 27, 2023

Fix #419

Summary

It seems that OOS sends UNLOCK requests instead of GET_LOCK with GetCurrentLock-00000000-0000-0000-0000-000000000000 as a lock token just to check the current lock. Also we still need the officeonline table for storing and comparing the lock tokens, as the server locking API currently doesn't expose methods to store a custom token.

Known issues to be documented in the README:

@juliusknorr juliusknorr added 2. developing Work in progress bug Something isn't working labels Mar 27, 2023
@juliusknorr juliusknorr marked this pull request as ready for review March 28, 2023 04:34
@luka-nextcloud
Copy link

@juliushaertl Seems like the switch-case statements are missing default case handlers.

@juliusknorr
Copy link
Member Author

@luka-nextcloud Expected in this case as we don't have a default path and just continue with the execution path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Simultanious editing broken in 2.0.0 with file_lock enabled

3 participants