Skip to content

chore: Switch to new API to set volatile user to prevent persisting it in any case #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
juliusknorr merged 2 commits into from
Dec 19, 2024
Merged

chore: Switch to new API to set volatile user to prevent persisting it in any case #606

juliusknorr merged 2 commits into from
Dec 19, 2024

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 19, 2024 •
edited
Loading

Mostly cherry-picking changes from richdocuments nextcloud/richdocuments#3833

Making use of nextcloud/server#44295

Steps to reproduce:

  • Have a groupfolder with ACL limited to block sharing
  • Try to open the file with officeonline (also works with a collabora instance)

@juliusknorr juliusknorr added 3. to review Waiting for reviews bug Something isn't working labels Dec 19, 2024
@juliusknorr juliusknorr requested review from blizzz and elzody December 19, 2024 11:40
@juliusknorr juliusknorr merged commit f13040b into main Dec 19, 2024
45 checks passed
@juliusknorr juliusknorr deleted the fix/wopi-session-user branch December 19, 2024 15:45
@juliusknorr juliusknorr mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzz blizzz blizzz approved these changes

@elzody elzody Awaiting requested review from elzody

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr @blizzz