Skip to content

[stable22] Fix password generation #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skjnldsv merged 3 commits into from
May 12, 2022
Merged

[stable22] Fix password generation #359

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
038eaee
Fix password generation
PVince81 May 12, 2022
fb95645
Fix old typo in length
PVince81 May 12, 2022
1d58f03
Use max() function for more compact code!
PVince81 May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use max() function for more compact code! 
Signed-off-by: Vincent Petry <[email protected]>
  • Loading branch information
@PVince81 @backportbot-nextcloud
PVince81 authored and backportbot-nextcloud[bot] committed May 12, 2022
commit 1d58f0362f6f16a96c6fe3d84f78c512fa125b6c
6 changes: 1 addition & 5 deletions lib/Generator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,7 @@ public function __construct(PasswordPolicyConfig $config,
* @throws HintException
*/
public function generate(): string {
$minLength = $this->config->getMinLength();
if ($minLength < 8) {
// 8 minimum so we don't generate too short passwords
$minLength = 8;
}
$minLength = max($this->config->getMinLength(), 8);
$length = $minLength;

$password = '';
Expand Down