fix: null password handling in entry control logic #453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #448
Fix nextcloud/user_saml#709
BeforeUserLoggedInEventis allowed to contain no password (string|null). However, the entry control logic fails if the password is null, because it always expects a string.I fixed this by also allowing null for the password. There is only one implementation of the
IEntryControlinterface in this app and it doesn't even make use of the password param so this should be safe change.There don't seem to be any other implementations of this interface outside this app (source: GitHub search for
IEntryControl).