Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Apr 4, 2023

Fix #448
Fix nextcloud/user_saml#709

BeforeUserLoggedInEvent is allowed to contain no password (string|null). However, the entry control logic fails if the password is null, because it always expects a string.

public function entryControl(string $loginName, string $password) {}

I fixed this by also allowing null for the password. There is only one implementation of the IEntryControl interface in this app and it doesn't even make use of the password param so this should be safe change.

There don't seem to be any other implementations of this interface outside this app (source: GitHub search for IEntryControl).

@st3iny
Copy link
Member Author

st3iny commented Apr 4, 2023

/backport to stable26

@solracsf
Copy link
Member

Can this be backported to 25?
nextcloud/user_saml#715

@st3iny
Copy link
Member Author

st3iny commented Apr 23, 2023

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

5 participants