Skip to content

Implement photos tag search #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marcelklehr wants to merge 4 commits into from
Closed

Implement photos tag search #1062

marcelklehr wants to merge 4 commits into from

Conversation

@marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Mar 22, 2022 •
edited
Loading

This implements tag search in photos directly, until nextcloud/server#26813 is merged.

Partially fixes #445

Peek 2022-03-22 12-58

Mikescops
Mikescops requested changes Mar 22, 2022
View reviewed changes
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@marcelklehr
Copy link
Member Author

marcelklehr commented Jun 10, 2022

/compile amend /

@marcelklehr
Copy link
Member Author

marcelklehr commented Jun 10, 2022

nextcloud/server#26813 is merged now, but this is still nice to have, I think

Mikescops
Mikescops approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@Mikescops Mikescops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great

This was referenced Aug 12, 2022
Merged
Merged
This was referenced Aug 24, 2022
Merged
Merged
This was referenced Sep 6, 2022
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@skjnldsv skjnldsv added the 2. developing Work in progress label Sep 20, 2022
@blizzz blizzz mentioned this pull request Sep 20, 2022
Closed
@marcelklehr
Implement photos tag search
7027793 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Remove lodash dependency
b93364b 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Fix after rebase
528ed92 
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr
Copy link
Member Author

marcelklehr commented Sep 21, 2022

rebased. Not sure what I did to upset eslint

@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@LovelyA72
Copy link

LovelyA72 commented Dec 31, 2022

Any update on this pr? This is a very useful feature when having a lot of tags.

@marcelklehr
Copy link
Member Author

marcelklehr commented Jan 1, 2023

This PR likely needs a rewrite since the photos 2.0 changes

@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
This was referenced May 3, 2023
Merged
Closed
Merged
@skjnldsv skjnldsv removed this from the Nextcloud 27 milestone May 10, 2023
@skjnldsv skjnldsv marked this pull request as draft May 10, 2023 09:46
@skjnldsv skjnldsv closed this Jan 7, 2025
@skjnldsv skjnldsv deleted the feat/search branch January 7, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mikescops Mikescops Mikescops approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

No one assigned

Labels

2. developing Work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search by date, multiple tag, location,.....

6 participants

@marcelklehr @LovelyA72 @Mikescops @blizzz @skjnldsv