Skip to content

Conversation

@jakobroehrl
Copy link
Contributor

Signed-off-by: Jakob [email protected]
fixes: #114

@jakobroehrl jakobroehrl requested a review from skjnldsv January 15, 2020 08:08
@Mikescops Mikescops added 3. to review Waiting for reviews bug Something isn't working labels Jan 15, 2020
@Mikescops Mikescops added this to the 1.0.0 milestone Jan 15, 2020
@jakobroehrl jakobroehrl force-pushed the fix/missingHeaderText branch from 8cade69 to 7e7ed83 Compare January 16, 2020 06:47
@jakobroehrl jakobroehrl requested a review from skjnldsv January 16, 2020 06:47
@jakobroehrl jakobroehrl force-pushed the fix/missingHeaderText branch from 7e7ed83 to fc03ae1 Compare January 16, 2020 10:25
@jakobroehrl jakobroehrl requested a review from skjnldsv January 16, 2020 10:27
@skjnldsv skjnldsv modified the milestones: 1.0.0, 1.1.0 Jan 16, 2020
@Mikescops
Copy link
Member

@jakobroehrl don't forget to lint your code, otherwise you don't pass the CI

@jakobroehrl jakobroehrl force-pushed the fix/missingHeaderText branch from 9cfe720 to defadcc Compare January 22, 2020 19:22
@jakobroehrl
Copy link
Contributor Author

@jakobroehrl don't forget to lint your code, otherwise you don't pass the CI

Done, I hope we can merge now.

@jakobroehrl jakobroehrl requested a review from Mikescops January 22, 2020 19:23
@jakobroehrl jakobroehrl force-pushed the fix/missingHeaderText branch from defadcc to 3ff7788 Compare January 23, 2020 11:14
@skjnldsv skjnldsv force-pushed the fix/missingHeaderText branch 2 times, most recently from 563668b to 3bc3453 Compare February 2, 2020 09:04
@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2020

/backport to stable18

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Feb 2, 2020
@skjnldsv skjnldsv force-pushed the fix/missingHeaderText branch from afca92a to 88ed0ab Compare February 2, 2020 09:28
@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2020

/compile /

Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 75f81f9 into master Feb 2, 2020
@skjnldsv skjnldsv deleted the fix/missingHeaderText branch February 2, 2020 09:31
@backportbot-nextcloud
Copy link

The backport to stable18 failed. Please do this backport manually.

@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2020

Backport in #172

@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Your photos" and "Favorites" miss heading text

4 participants