FaceCovers: Hide first description line if there's no face title #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you show how it looks like with 1 person actually having a name set? It would be good if the text baseline is the same, no matter if it’s a name or a "x photos" line. (I am thinking that probably the "x photos" lines are a bit further up cause they are smaller, so would be nice to align them.) |
Member
Author
|
jancborchardt
approved these changes
Sep 14, 2022
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Looks great, thank you! :)
marcelklehr
force-pushed
the
fix/hide-empty-face-title
branch
2 times, most recently
from
579cca8 to
59c71ae
Compare
Member
Author
|
/compile amend /js |
nextcloud-command
force-pushed
the
fix/hide-empty-face-title
branch
from
59c71ae to
407f897
Compare
marcelklehr
force-pushed
the
fix/hide-empty-face-title
branch
from
407f897 to
b0d13ba
Compare
Member
Author
|
/compile amend /js |
Signed-off-by: Marcel Klehr <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/hide-empty-face-title
branch
from
b0d13ba to
0d42e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.