Skip to content

Polishing of backend code for albums #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 4 commits into from
Sep 16, 2022
Merged

Polishing of backend code for albums #1245

skjnldsv merged 4 commits into from
Sep 16, 2022

Conversation

@artonge
Copy link
Collaborator

@artonge artonge commented Sep 16, 2022 •
edited
Loading

  • Minor polishing of backend code for albums
  • Use album owner if album file owner is null
  • Rename collaborator.source to .type
  • Add more e2e tests, but they are skipped for now

@artonge artonge added 2. developing Work in progress feature: albums Related to the albums section labels Sep 16, 2022
@artonge artonge added this to the Nextcloud 25 milestone Sep 16, 2022
@artonge artonge self-assigned this Sep 16, 2022
@artonge artonge force-pushed the feat/polish_collaboration branch from 449200a to 43316a6 Compare September 16, 2022 11:59
@artonge
Overall polishing of backend code for albums
331e2c7 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
Use album owner if album file owner is null
58947bb 
Signed-off-by: Louis Chemineau <[email protected]>
@artonge
Rename collaborator.source to .type
73e726a 
And do the mapping in the frontend

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the feat/polish_collaboration branch from 55ed8b0 to b4de9cc Compare September 16, 2022 12:41
@artonge

This comment was marked as resolved.

Sign in to view
@artonge @nextcloud-command
Add more e2e tests
46d9982 
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@artonge artonge changed the title Overall polishing of backend code for albums Polishing of backend code for albums Sep 16, 2022
@skjnldsv skjnldsv merged commit fd94986 into master Sep 16, 2022
@skjnldsv skjnldsv deleted the feat/polish_collaboration branch September 16, 2022 12:52
@blizzz blizzz mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels

2. developing Work in progress feature: albums Related to the albums section

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

3 participants

@artonge @skjnldsv