Do not get all the files list when fetching the albums list #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
3. to review
skjnldsv
requested review from
PVince81 and
juliusknorr
and removed request for
a team
artonge
approved these changes
Sep 22, 2022
Collaborator
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Other endpoints have probably the same issue. Let's merge this one and see later for the others
Member
|
/backport to stable25 |
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
force-pushed
the
feat/perf-albums
branch
from
ce7e310 to
804b92f
Compare
backportbot-nextcloud
bot
added
the
backport-request
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #1238
/remote.php/dav/photos/admin/albums/We used to fetch all albums WITH files. That meant fetching literally ALL the files in all albums for a specific user, so it will quickly get expensive
Advice welcome, we should also have psalm somewhere here! 🙈 @CarlSchwan