-
-
Notifications
You must be signed in to change notification settings - Fork 77
Fix Scroll under add collaborators #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix for #1271 Signed-off-by: Andy Xheli <[email protected]>
|
/compile amend / |
|
@artonge All set! |
|
/compile amend / |
|
Hey @AndyXheli could you compile and squash ? I can't do it as your branch is on your repository |
This comment was marked as outdated.
This comment was marked as outdated.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Can you check your npm version ? It should be 7 or above |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Weird, as you already force pushed on this branch without any issue. Anyway, you can push normally, without --force. Don't forget to create a new commit, I don't see this step in your shell output |
Fix scroll Signed-off-by: Andy Xheli <[email protected]>
|
@artonge I got it! Thank you for your support :) Please review |
|
Great ! Could you tell me what was blocking ? Just to know for next time. |
All I did was delete the photos folder from my computer then i when into my ford redownload it then did a gh pr checkout 1312 and i didnt get the error. Maybe i was doing something wrong ? |
|
/backport to stable25 |
Fix for #1271
@artonge please review
Signed-off-by: Andy Xheli [email protected]